sound/gb.cpp: Updates/Cleanups: #13483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use single integer for pulse duty table - Fix master volume - Make some variables constant - Reduce duplicates - Fix typenames for boolean flags - Fix outputs - Fix docs, Fix namings
cuavas
reviewed
Apr 8, 2025
Comment on lines
-417
to
+407
| snd.signal = wave_duty_table[snd.duty][snd.duty_count]; | ||
| snd.signal = BIT(wave_duty_table[snd.duty], snd.duty_count); |
There was a problem hiding this comment.
This changes the output for these channels from balanced -1/+1 to unbalanced 0/+1 levels. Is that correct? Can you provide a reference for this change in behaviour?
There was a problem hiding this comment.
That is digital sample, and converted at DAC output.
reference: https://gbdev.io/pandocs/Audio_details.html
cuavas
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://gbdev.io/pandocs/