multibus: fixed regression on isbc202 #13594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Apr 15, 2025
| #define IPC_XTAL_Y1 19.6608_MHz_XTAL | ||
| constexpr auto IPC_XTAL_Y1 = 19.6608_MHz_XTAL; |
There was a problem hiding this comment.
If you turn this into a global variable, it needs to have a constant address across an invocation and hence increases static data size. If it’s only used in a single function, you can make it a local variable.
There was a problem hiding this comment.
Aren't constexpr variables implicitly inline since C++17?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this commit fixes a regression on isbc202 emulation caused by cf67936, which removed ownership of multibus slots by multibus bus. By doing so it removed the propagation of clock down to cards.
iSBC202 was affected because it (probably) is the only multibus card in MAME that relies on clock to come from the bus.
Thanks.
--F.Ulivi