Skip to content

Possible fix for #144. #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 23, 2016
Merged

Possible fix for #144. #145

merged 6 commits into from
Dec 23, 2016

Conversation

StyXman
Copy link
Contributor

@StyXman StyXman commented Nov 3, 2016

This PR proposes a fix for #144. It WorksForMe™, but I don't know all the internals of DRFDocs. I just hope this makes the ball start rolling.

This patch accumulates parent_regexps with the current one, but changes the ABI, so there's a second patch to come to fix `ApiEndpoint`
This patch fixes the ABI changed in `ApiDocumentation`.
I shuld do local dev instead of edit via GitHub's page...
3 and counting...
@tadgh
Copy link

tadgh commented Nov 15, 2016

Tested this locally, solves it for me as well

@manosim
Copy link
Owner

manosim commented Dec 12, 2016

Hello @StyXman! I'm sorry for the late reply - been really busy - trying to find more time for drfdocs & other open-source projects but it can be really tough. I will be more than happy to give you push access to the repository & pypi so that I don't slow down everyone (sorry about this!)... Let me know if you are interested!

@StyXman
Copy link
Contributor Author

StyXman commented Dec 13, 2016

@manosim: yes, I can at least merge a couple of PRs, and if you're happy with it, think about a release. With a little bit of luck I can do it in work hours :)

@manosim
Copy link
Owner

manosim commented Dec 13, 2016

@StyXman Sounds great! Can you send me a dm on twitter (@manosim_) to give me your pypi username etc?

@StyXman
Copy link
Contributor Author

StyXman commented Dec 13, 2016

My pypi username is the same as my github one, what else do you need?

@manosim
Copy link
Owner

manosim commented Dec 13, 2016

Just added you to PyPI as well so that should be good to go? Let me know if there is anything else I can help with! Thank you for stepping up on this one! Really appreciate it!

@StyXman StyXman mentioned this pull request Dec 20, 2016
@StyXman StyXman merged commit 6673ef2 into manosim:master Dec 23, 2016
@ConorMcGee
Copy link

Any idea when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants