Skip to content

Upgrades to Swift 6 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrades to Swift 6 #74

wants to merge 6 commits into from

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Mar 16, 2025 •
edited
Loading

Issue/Motivation

  • Upgrades the project to swift 6

Tasklist

  • Include tests (if applicable) and examples (new or edits)
  • If there are any visual changes as a result, include before/after screenshots and/or videos
  • Add #fixes with the issue number that this PR addresses
  • Update any documentation for affected APIs
  • Update the CHANGELOG

hactar
hactar reviewed Mar 16, 2025
View reviewed changes
Copy link
Collaborator

@hactar hactar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but not passing tests.

@Archdoog
Copy link
Collaborator Author

Changes look good, but not passing tests.

This is a weird issue with swift snapshot testing, where it lists out that it can't find the files on the simulator's file system, not the typical Xcode project/local directory. Maybe some change with that library and/or something with the assertView wrapper.

Will have to play around with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hactar hactar hactar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archdoog @hactar