dotnet#1603: Don't display Job and Toolchain column when running benchmarks for multiple runtimes

Author: [email protected]

src/BenchmarkDotNet/Columns/JobCharacteristicColumn.cs

@@ -28,7 +28,6 @@ private JobCharacteristicColumn(Characteristic characteristic)
 
         public string Id { get; }
         public string ColumnName { get; }
-        public bool IsAvailable(Summary summary) => true;
         public bool AlwaysShow => false;
         public ColumnCategory Category => ColumnCategory.Job;
         public int PriorityInCategory => 0;
@@ -38,6 +37,23 @@ private JobCharacteristicColumn(Characteristic characteristic)
 
         public bool IsDefault(Summary summary, BenchmarkCase benchmarkCase) => !benchmarkCase.Job.HasValue(characteristic);
 
+        public bool IsAvailable(Summary summary)
+        {
+            if (summary.IsMultipleRuntime)
+            {
+                if (nameof(Toolchains.Toolchain).Equals(ColumnName))
+                {
+                    return false;
+                }
+                if (nameof(Job).Equals(ColumnName))
+                {
+                    return summary.BenchmarksCases.Any(x => !x.Job.IsGeneratedJobId());
+                }
+            }
+
+            return true;
+        }
+
         public string GetValue(Summary summary, BenchmarkCase benchmarkCase)
         {
             if (!benchmarkCase.Job.HasValue(characteristic) && EnvironmentResolver.Instance.CanResolve(characteristic))

src/BenchmarkDotNet/Jobs/JobIdGenerator.cs

@@ -1,21 +1,36 @@
 using System;
+using System.Linq;
 using BenchmarkDotNet.Characteristics;
 
 namespace BenchmarkDotNet.Jobs
 {
     public static class JobIdGenerator
     {
+        private const int JobIdLength = 10;
+        private const string JobIdPrefix = "Job-";
+        private const string DefaultJobId = "DefaultJob";
+
         public static string GenerateRandomId(Job job)
         {
             string presentation = CharacteristicSetPresenter.Display.ToPresentation(job);
-            if (presentation == "")
-                return "DefaultJob";
+            if (presentation == string.Empty)
+                return DefaultJobId;
             int seed = presentation.GetHashCode();
             var random = new Random(seed);
-            string id = "";
+            string id = string.Empty;
             for (int i = 0; i < 6; i++)
-                id += (char) ('A' + random.Next(26));
-            return "Job-" + id;
+                id += (char)('A' + random.Next(26));
+            return JobIdPrefix + id;
+        }
+
+        public static bool IsGeneratedJobId(this Job job)
+        {
+            return job.ResolvedId == DefaultJobId
+                || (job.ResolvedId.Length == JobIdLength
+                && job.ResolvedId.StartsWith(JobIdPrefix)
+                && job.ResolvedId.Replace(JobIdPrefix, string.Empty)
+                .ToCharArray()
+                .All(x => char.IsLetter(x)));
         }
     }
 }

src/BenchmarkDotNet/Reports/Summary.cs

@@ -75,6 +75,8 @@ public Summary(
 
         public int GetNumberOfExecutedBenchmarks() => Reports.Count(report => report.ExecuteResults.Any(result => result.FoundExecutable));
 
+        public bool IsMultipleRuntime => BenchmarksCases.Count() > 1 ? BenchmarksCases.Where(benchmark => benchmark.Job.Environment.Runtime != null).Any(benchmark => !benchmark.Job.Environment.Runtime.Equals(BenchmarksCases[0].Job.Environment.Runtime)) : false;
+
         internal static Summary NothingToRun(string title, string resultsDirectoryPath, string logFilePath)
             => new Summary(title, ImmutableArray<BenchmarkReport>.Empty, HostEnvironmentInfo.GetCurrent(), resultsDirectoryPath, logFilePath, TimeSpan.Zero, DefaultCultureInfo.Instance, ImmutableArray<ValidationError>.Empty);