Skip to content

Don't display Job and Toolchain column when running benchmarks for multiple runtimes #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adamsitnik opened this issue Nov 23, 2020 · 7 comments · Fixed by #1890
Closed

Don't display Job and Toolchain column when running benchmarks for multiple runtimes #1603

adamsitnik opened this issue Nov 23, 2020 · 7 comments · Fixed by #1890
Labels
good first issue up-for-grabs
Milestone
v0.13.2

Comments

@adamsitnik
Copy link
Member

The Job and Toolchain columns are redundant, Runtime is all we need:

obraz

I see this very often when our users are presenting BDN results at conferences|meetups etc

The Job column should remain visible when the user has set the Job id in explicit way.

/cc @stephentoub
@adamsitnik adamsitnik added this to the v0.13.x milestone Nov 23, 2020
marcnet80 pushed a commit to marcnet80/BenchmarkDotNet that referenced this issue Dec 17, 2020
dotnet#1603: Don't display Job and Toolchain column when running benc…
f86874a 
…hmarks for multiple runtimes
@marcnet80 marcnet80 mentioned this issue Dec 17, 2020
Merged
@marcnet80
Copy link
Contributor

Hello, @adamsitnik, please review PR.
Thanks.

@kevinsalimi
Copy link
Contributor

What's the status for this?

@lipchev
Copy link

lipchev commented May 24, 2021

This would indeed be very helpful- it is just the amount of space my reports need in order to avoid line wrapping..

Additionally I think the same logic applies to the rplot build script. My customization of it, simply replaces all occurrences of Job_Id with Job_Runtime making for a much more useful legend (although Job_Toolchain is also a good option- if you don't want to have white spaces in the file name)

@jkrueger721
Copy link

Is this still open?

@kevinsalimi
Copy link
Contributor

Is this still open?

From that time onward, unfortunately, I couldn't spend time on this issue. If you can, please go ahead.
Thank you for your help.

@jkrueger721
Copy link

@adamsitnik I would like to take over this issue.

@mawosoft mawosoft mentioned this issue Nov 9, 2021
Closed
@YegorStepanov YegorStepanov mentioned this issue Jan 11, 2022
Merged
@adamsitnik adamsitnik modified the milestones: v0.13.x, v0.13.2 Aug 25, 2022
adamsitnik added a commit that referenced this issue Aug 25, 2022
@marcnet80 @adamsitnik
Hide columns for multiple runtime (#1621)
8380003 
* #1603: Don't display Job and Toolchain column when running benchmarks for multiple runtimes

* pedantic improvements: rename IsMultipleRuntime to IsMultipleRuntimes

make it Lazy

don't use Count() when Length is available

* use simpler way of checking whether Id was assigned by the user in explicit way

Co-authored-by: [email protected] <marc90>
Co-authored-by: Adam Sitnik <[email protected]>
@adamsitnik
Copy link
Member Author

Fixed by #1621

@YegorStepanov YegorStepanov mentioned this issue Nov 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue up-for-grabs
Projects
None yet
Milestone
v0.13.2
Development

Successfully merging a pull request may close this issue.

Hiding columns YegorStepanov/BenchmarkDotNet
5 participants
@lipchev @adamsitnik @jkrueger721 @marcnet80 @kevinsalimi