Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: should make SSE endpoint the same as official MCP servers #71

Closed
deadprogram opened this issue Mar 25, 2025 · 3 comments · Fixed by #91
Closed

server: should make SSE endpoint the same as official MCP servers #71

deadprogram opened this issue Mar 25, 2025 · 3 comments · Fixed by #91

Comments

@deadprogram
Copy link
Contributor

Hello, there! Thanks for this very useful project.

While doing some testing recently, it was pointed out to me that the typical endpoint for SSE is messages (plural) not message (singular) as it is in this project.

See https://github.com/mark3labs/mcp-go/blob/main/server/sse.go#L126

For example, see how the official Python SDK does it here:
https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/server/sse.py#L14

If agreed, I am happy to submit a PR with this change.
@ezynda3
Copy link
Contributor

ezynda3 commented Mar 25, 2025

Hi @deadprogram I'm happy to accept a PR for this. Also FYI there is a way to set a custom endpoint name if you like. Also I believe that the endpoint is something that is exchanged during initialization so technically shouldn't matter?

@deadprogram
Copy link
Contributor Author

Also FYI there is a way to set a custom endpoint name if you like.

I am currently using that, thanks for mentioning.

Also I believe that the endpoint is something that is exchanged during initialization so technically shouldn't matter?

That is true, however not all MCP clients are well behaved, apparently.

@a67793581
Copy link
Contributor

Also FYI there is a way to set a custom endpoint name if you like.

I am currently using that, thanks for mentioning.

Also I believe that the endpoint is something that is exchanged during initialization so technically shouldn't matter?

That is true, however not all MCP clients are well behaved, apparently.

I'm glad you found this. I think you should submit this PR. I hope you can submit it as soon as possible.

deadprogram added a commit to hybridgroup/mcp-go that referenced this issue Mar 30, 2025
@deadprogram
fix: make the default sse endpoint match the standard one used in the…
e872ba8 
… official servers. Fixes mark3labs#71

Signed-off-by: deadprogram <[email protected]>
@deadprogram deadprogram mentioned this issue Mar 30, 2025
Merged
deadprogram added a commit to hybridgroup/mcp-go that referenced this issue Apr 6, 2025
@deadprogram
fix: make the default sse endpoint match the standard one used in the…
41cbb39 
… official servers. Fixes mark3labs#71

Signed-off-by: deadprogram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@deadprogram @ezynda3 @a67793581