Skip to content

fix: change the default SSE endpoint to match the standard one used in the official servers #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

deadprogram
Copy link
Contributor

@deadprogram deadprogram commented Mar 30, 2025

This PR changes the default SSE endpoint to messages to match the standard one used in the official servers.

Fixes #71

Summary by CodeRabbit

  • Refactor
    • Updated the messaging API endpoint from a singular to a pluralized path for improved clarity and consistency.

Copy link
Contributor

coderabbitai bot commented Mar 30, 2025

Walkthrough

This pull request updates the SSE server initialization by changing the messageEndpoint field from "/message" to "/messages" in the NewSSEServer function. The update aligns the endpoint naming with the official MCP server implementation. No additional logic, error handling, or control flow was modified.

Changes

File(s) Change Summary
server/sse.go Updated messageEndpoint from "/message" to "/messages" in the NewSSEServer function.

Assessment against linked issues

Objective Addressed Explanation
SSE endpoint consistency (#71)

Possibly related PRs

  • fix(examples/everything): add WithBaseURL #48: The changes in the main PR modify the messageEndpoint field in the NewSSEServer function, while the retrieved PR alters the function signature of NewSSEServer to include a new parameter, indicating that they are related through modifications to the same function.
  • fix java mcp message endpoint #75: The changes in the main PR modify the messageEndpoint field in the SSEServer struct, while the retrieved PR introduces a new field and modifies the logic for generating the message endpoint, indicating a direct relationship in their handling of the messageEndpoint.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e872ba8 and 41cbb39.

📒 Files selected for processing (1)
  • server/sse.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • server/sse.go

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@deadprogram
Copy link
Contributor Author

Just corrected the merge conflict so this PR should now be ready. Thanks!

@deadprogram
Copy link
Contributor Author

Gentle reminder to maintainers, if you please... 😸

@ezynda3 ezynda3 merged commit d1e5f33 into mark3labs:main Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: should make SSE endpoint the same as official MCP servers
2 participants