Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

chore(menu): Rename SimpleMenu to Menu #2061

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

williamernest
Copy link
Contributor

BREAKING CHANGE: Renames MDCSimpleMenu to MDCMenu. Renames all mdc-simple-menu classes to mdc-menu.

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #2061 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2061   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          84       84           
  Lines        3720     3720           
  Branches      485      485           
=======================================
  Hits         3699     3699           
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-menu/constants.js 100% <ø> (ø)
packages/mdc-select/foundation.js 100% <ø> (ø) ⬆️
packages/mdc-select/index.js 100% <100%> (ø) ⬆️
packages/mdc-menu/index.js 100% <100%> (ø)
packages/mdc-menu/foundation.js 99.26% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd41b60...91c8016. Read the comment docs.

@acdvorak acdvorak self-assigned this Jan 24, 2018
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In the BREAKING CHANGE message, make sure to also mention that the JS and Sass file paths have changed.

@williamernest williamernest merged commit 26c9aec into master Jan 24, 2018
@williamernest williamernest deleted the chore/menu/rename-simple-menu branch January 24, 2018 16:20
sadovnychyi added a commit to sadovnychyi/react-mdc-web that referenced this pull request Mar 8, 2018
kradio3 pushed a commit to kradio3/react-mdc-web that referenced this pull request Mar 9, 2018
@Kerrick
Copy link
Contributor

Kerrick commented Aug 6, 2018

This broke the util export from #824

@williamernest
Copy link
Contributor Author

@Kerrick Thanks for catching this. I'll be adding this back in the new mdc-menu-surface package coming in the next major release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants