-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(ripple): export util from @material/ripple #751
Conversation
Related issue is #253. It also mentions that docs for ripple need to be expanded. |
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 69 69
Lines 3181 3181
Branches 387 387
=======================================
Hits 3148 3148
Misses 33 33
Continue to review full report at Codecov.
|
Actually, I approved a little too quickly...could you also add documentation to the README? And put Resolves #253: in the body of the commit. |
The docs already say the following under Using the foundation:
What more should I document about it? Also, should I add an example to the ES2015 etc. imports (example below)? Was wondering about that since it's under Adding the ripple JS rather than Using the foundation. import {MDCRipple, MDCRippleFoundation, util} from '@material/ripple'; I'll be glad to make the requested changes once I'm a bit clearer on what's best. 👍 |
Mdc-drawer has a good example of documenting The util API Mdc-ripple README should document
And, again using mdc-drawer as an example, looks like you should add
Thank you! |
Hi @Kerrick, trying to loop back to see if there is any updates :) Let us know if there is anything you need us help for clarification. |
Whoops, sorry about that! Got caught up in a big product launch at work and lost track. Should be able to get these changes back to you shortly. |
Resolves material-components#253: The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. Export util from index.js so this is possible.
I've pushed the requested changes 👍 |
Resolves #253: The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. Export util from index.js so this is possible.
The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. It is not currently possible to
import { util } from '@material/ripple';
, even though this pattern is established inmdc-toolbar
.