Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(ripple): export util from @material/ripple #751

Merged
merged 3 commits into from
Jun 23, 2017

Conversation

Kerrick
Copy link
Contributor

@Kerrick Kerrick commented May 30, 2017

The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. It is not currently possible to import { util } from '@material/ripple';, even though this pattern is established in mdc-toolbar.

@anton-kachurin
Copy link
Contributor

Related issue is #253. It also mentions that docs for ripple need to be expanded.

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          69       69           
  Lines        3181     3181           
  Branches      387      387           
=======================================
  Hits         3148     3148           
  Misses         33       33
Impacted Files Coverage Δ
packages/mdc-ripple/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107980a...560648d. Read the comment docs.

@lynnmercier
Copy link
Contributor

Actually, I approved a little too quickly...could you also add documentation to the README? And put Resolves #253: in the body of the commit.

@Kerrick
Copy link
Contributor Author

Kerrick commented Jun 1, 2017

The docs already say the following under Using the foundation:

We provide a supportsCssVariables function within the util.js which we recommend using, as it handles this for you.

What more should I document about it?

Also, should I add an example to the ES2015 etc. imports (example below)? Was wondering about that since it's under Adding the ripple JS rather than Using the foundation.

import {MDCRipple, MDCRippleFoundation, util} from '@material/ripple';

I'll be glad to make the requested changes once I'm a bit clearer on what's best. 👍

@lynnmercier
Copy link
Contributor

Mdc-drawer has a good example of documenting The util API

https://github.com/material-components/material-components-web/tree/master/packages/mdc-drawer

Mdc-ripple README should document

  • supportsCssVariables
  • applyPassive
  • getMatchesProperty
  • getNormalizedEventCoords

And, again using mdc-drawer as an example, looks like you should add

import {MDCRipple, MDCRippleFoundation, util} from '@material/ripple';

Thank you!

@yeelan0319
Copy link
Contributor

Hi @Kerrick, trying to loop back to see if there is any updates :)

Let us know if there is anything you need us help for clarification.

@Kerrick
Copy link
Contributor Author

Kerrick commented Jun 13, 2017

Whoops, sorry about that! Got caught up in a big product launch at work and lost track. Should be able to get these changes back to you shortly.

Resolves material-components#253: The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. Export util from index.js so this is possible.
@Kerrick
Copy link
Contributor Author

Kerrick commented Jun 19, 2017

I've pushed the requested changes 👍

@lynnmercier lynnmercier merged commit 27c172a into material-components:master Jun 23, 2017
lynnmercier pushed a commit that referenced this pull request Jun 27, 2017
Resolves #253: The docs recommend using certain functions from util when implementing an adapter for the ripple foundation. Export util from index.js so this is possible.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants