This repository was archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs(elevation): Simplify README to follow proposed best practices #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 69 69
Lines 3181 3181
Branches 387 387
=======================================
Hits 3148 3148
Misses 33 33 Continue to review full report at Codecov.
|
amsheehan
approved these changes
Jun 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, just remove that "s" and we're good to go!
🥇
packages/mdc-elevation/README.md
Outdated
If you need more configurability over your transitions, you can easily accomplish this by using | ||
the `mdc-elevation-transition-rule` function in conjunctions with the exported sass variables that | ||
mdc-elevation exposes for purposes of transitioning. | ||
If you need more configurability over your transitions, use the `mdc-elevation-transition-rule` function in conjunctions with the exported sass variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the "s" from "conjunction"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.