Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-input-chip: leading padding is incorrect #5784

Open
HarmfulBreeze opened this issue Mar 13, 2025 · 1 comment · May be fixed by #5791
Open

md-input-chip: leading padding is incorrect #5784

HarmfulBreeze opened this issue Mar 13, 2025 · 1 comment · May be fixed by #5791

Comments

@HarmfulBreeze
Copy link

HarmfulBreeze commented Mar 13, 2025 •
edited
Loading

What is affected?

Component

Description

According to the design doc[1], leading-space should be 12px, whereas it currently is 16px in the code[2].

[1] https://m3.material.io/components/chips/specs#1dcff1cb-22f5-41da-809e-6c85b467cff1
[2]

material-web/tokens/_md-comp-input-chip.scss

Line 133 in 898e9c1

'leading-space': if($exclude-hardcoded-values, null, 16px),

Reproduction

N/A

Workaround

N/A

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

Failing in 2.2.0

Browser/OS/Node environment

N/A
@HarmfulBreeze HarmfulBreeze changed the title md-filter-chip: leading padding is incorrect md-input-chip: leading padding is incorrect Apr 3, 2025
HarmfulBreeze added a commit to HarmfulBreeze/material-web that referenced this issue Apr 3, 2025
@HarmfulBreeze
fix(chip): set input chip leading-space to 12px
38f780d 
According to the design doc, leading padding should be 12dp rather than 16.

Fixes: material-components#5784
@HarmfulBreeze HarmfulBreeze linked a pull request Apr 3, 2025 that will close this issue
Open
@HarmfulBreeze
Copy link
Author

Sorry for mixing up filter chip and input chip 😅
Filter chip looks fine, I think only input chip's padding needs to be adjusted. I edited the issue accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chip): set input chip leading-space to 12px HarmfulBreeze/material-web
1 participant
@HarmfulBreeze