Skip to content

Fix spelling errors. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2016
Merged

Fix spelling errors. #149

merged 2 commits into from
Jul 11, 2016

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 11, 2016

This fixes my dopy-and-pasted spelling error in "protocol". I thought I remembered Peter already doing that, but it seems not to be fixed, so I'm submitting this pull request to do so.

@pkra
Copy link
Contributor

pkra commented Jul 11, 2016

I thought I remembered Peter already doing that,

That happened in the core -- mathjax/MathJax#1527 😸

@@ -150,7 +150,7 @@ MathJax.Hub.Register.StartupHook('Sre Ready', function() {
if (MathJax.Menu) {
var menu = MathJax.Menu.menu.FindId('Explorer');
if (menu) {
var items = menu.submenu.items;
var items = (menu.submenu||menu.menu).items;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zorkow (since I don't know the code)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that shouldn't have been there. It was left over from my trying to get it to work in v2.5 (there was a name change in the menus in v2.6).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the change.

@dpvc
Copy link
Member Author

dpvc commented Jul 11, 2016

That happened in the core

Thanks! I thought I was losing my memory.

@pkra
Copy link
Contributor

pkra commented Jul 11, 2016

LGTM!

@dpvc dpvc merged commit 5f23c44 into master Jul 11, 2016
@dpvc dpvc deleted the fix-protocol branch July 11, 2016 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants