Skip to content

Make sure padding and margin can accept 0 to mean 0px. #244 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 10, 2016

Make sure padding and margin can accept 0 to mean 0px. Resolves issue #244

@pkra pkra added this to the What comes next -- towards v1.0 milestone Jun 13, 2016
@pkra
Copy link
Contributor

pkra commented Jun 13, 2016

I can't really comment on what it does but the code looks good to me.

@pkra
Copy link
Contributor

pkra commented Jun 14, 2016

@dpvc I still see the issue (though it's not as bad as before). Example: http://codepen.io/pkra/pen/YWqRLB.

I'm using MathJax's develop branch and this branch.

@dpvc
Copy link
Member Author

dpvc commented Jun 21, 2016

I still see the issue (though it's not as bad as before).

That turns out to be independent of this PR, so I'd recommend merging this for now. The problem you are having is very dependent on the font size and zoom level (for me), and is probably due to rounding issues. The labels are in a separate column that has spacing added to (theoretically) make it match the table row sizes, but the imprecise knowledge of the em and ex size affect this, as does the fact that the table is made of pieces with different heights than the labels, so the cumulative around-off error is different. Also, the error is additive, so it gets more and more several as you go down the table.

I'm not sure how to fix it, but any solution will have to be in the CommonHTML code, not mathjax-node. I'll see what I can come up with.

@pkra pkra merged commit 0575517 into develop Jun 21, 2016
@pkra
Copy link
Contributor

pkra commented Jun 21, 2016

I'm not sure how to fix it, but any solution will have to be in the CommonHTML code, not mathjax-node. I'll see what I can come up with.

Will you open an issue upstream?

@dpvc
Copy link
Member Author

dpvc commented Jun 21, 2016

Done. mathjax/MathJax#1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants