Fix vector arrow positioning in CHTML. #1543 #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to fix in CSS in PR mathjax#1448). Resolves issue mathjax#1543.
| @@ -1882,7 +1882,7 @@ | |||
| // something, so put them over a space and remove the space's width | |||
| // | |||
| node = node.firstChild; | |||
| var space = CHTML.Element("mjx-span",{style:{width:".25em","margin-left":"-.25em"}}); | |||
| var space = CHTML.Element("mjx-box",{style:{width:".25em","margin-left":"-.25em"}}); | |||
There was a problem hiding this comment.
I assume this does not have any implications on CSS behaviour?
There was a problem hiding this comment.
Only the desired one of making it work. :-)
The only CSS that these two set is the display value, and that is what needs to be changed. So there are no side-effects of this.
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change class to mjx-box so that width will have the proper effect (due to fix in CSS in PR #1448). Resolves issue #1543.