Skip to content

[CommonHTML] fix typo in styles #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2016
Merged

[CommonHTML] fix typo in styles #1448

merged 1 commit into from
May 2, 2016

Conversation

pkra
Copy link
Contributor

@pkra pkra commented Apr 21, 2016

Fixes #1443

@pkra
Copy link
Contributor Author

pkra commented Apr 21, 2016

On the other hand, this style is redundant, no?

@dpvc
Copy link
Member

dpvc commented Apr 29, 2016

On the other hand, this style is redundant, no?

No. A few lines earlier, you see

".mjx-math *": {display:"inline-block", "text-align":"left"},

which makes everything inside the CHTML output be inline-block by default. So this mjx-span class allows you to get back to regular inline elements when needed. But apparently that never actually worked.

@pkra
Copy link
Contributor Author

pkra commented May 2, 2016

No. A few lines earlier, you see

Thanks, I had missed that!

@pkra pkra mentioned this pull request May 2, 2016
Closed
@dpvc dpvc merged commit 5fc8bc2 into develop May 2, 2016
@dpvc dpvc deleted the issue1443 branch May 2, 2016 23:06
dpvc added a commit to dpvc/MathJax that referenced this pull request Jul 5, 2016
@dpvc
Change class to mjx-box so that width will have the proper effect (du…
595d38e 
…e to fix in CSS in PR mathjax#1448).  Resolves issue mathjax#1543.
@dpvc dpvc mentioned this pull request Jul 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkra @dpvc