Use currentColor rather than black for menclose with no math color. #1573 #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specified. Resolves issue mathjax#1573.
|
LGTM. |
| @@ -113,7 +113,7 @@ MathJax.Hub.Register.StartupHook("SVG Jax Ready",function () { | |||
| t = Math.max(1/SVG.em,t); // see issue #414 | |||
| var H = base.h+p+t, D = base.d+p+t, W = base.w+2*(p+t); | |||
| var dx = 0, w, h, i, m, borders = [false,false,false,false]; | |||
| if (!values.mathcolor) {values.mathcolor = "black"} | |||
| if (!values.mathcolor) {values.mathcolor = "currenColor"} | |||
There was a problem hiding this comment.
Missing 't'? Should that not be "currentColor"?
There was a problem hiding this comment.
I missed it, too. The code worked because when the color attribute was set, it didn't match a valid color and was ignored, meaning that the color was inherited anyway. I'll fix it. We might be able to leave that line out entirely.
|
It turns out we don't need the I don't think this needs more review, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use currentColor rather than black for menclose when mathcolor isn't specified.
Resolves issue #1573.