Skip to content

[SVG, HTML-CSS output] menclose does not inherit color #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pkra opened this issue Aug 4, 2016 · 4 comments
Closed

[SVG, HTML-CSS output] menclose does not inherit color #1573

pkra opened this issue Aug 4, 2016 · 4 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.7
Milestone
MathJax v2.7.0

Comments

@pkra
Copy link
Contributor

pkra commented Aug 4, 2016 •
edited
Loading

Via the user group.

For SVG, it looks like we forget menclose in #1002. This seems to be it: https://github.com/mathjax/MathJax/blob/master/unpacked/jax/output/SVG/autoload/menclose.js#L116.

For HTML-CSS it seems to be https://github.com/mathjax/MathJax/blob/master/unpacked/jax/output/HTML-CSS/autoload/menclose.js#L58
@pkra pkra added the Accepted Issue has been reproduced by MathJax team label Aug 4, 2016
@pkra pkra added this to the MathJax v2.7.0 milestone Aug 4, 2016
@pkra pkra changed the title [SVG output] menclose does not inherit color [SVG, HTML-CSS output] menclose does not inherit color Aug 4, 2016
@pkra
Copy link
Contributor Author

pkra commented Aug 4, 2016

Edited my OP with information for HTML-CSS.

dpvc added a commit to dpvc/MathJax that referenced this issue Aug 4, 2016
@dpvc
Use currentColor rather than black for menclose when mathcolor isn't …
13cd707 
…specified. Resolves issue mathjax#1573.
@dpvc
Copy link
Member

dpvc commented Aug 4, 2016

The issue1573 branch of my fork of MathJax includes the fix. Thanks for finding the lines that caused the problem.

@dpvc dpvc mentioned this issue Aug 4, 2016
Merged
dpvc added a commit to dpvc/MathJax that referenced this issue Aug 5, 2016
@dpvc
Don't need to use currentColor after all. Issue mathjax#1573.
317f838
dpvc added a commit that referenced this issue Aug 5, 2016
@dpvc
Merge pull request #1574 from dpvc/issue1573
4779c91 
Use currentColor rather than black for menclose with no math color.  #1573
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Aug 5, 2016
@dpvc
Copy link
Member

dpvc commented Aug 5, 2016

==> Merged

@dpvc dpvc closed this as completed Aug 5, 2016
dpvc added a commit to mathjax/MathJax-test that referenced this issue Aug 12, 2016
@dpvc
Add test for mathjax/MathJax#1573
3ba0cd2
@dpvc
Copy link
Member

dpvc commented Aug 12, 2016

==> In testsuite

MathMLToDisplay/Presentation/GeneralLayout/menclose/issue1573.html

@dpvc dpvc added v2.7 Fixed and removed Merged Merged into develop branch labels Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.7
Projects
None yet
Milestone
MathJax v2.7.0
Development

No branches or pull requests
2 participants
@pkra @dpvc