Make sure 0 remains 0 when rounding to pixels (plus a bit). #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2937,7 +2937,9 @@ | |||
| // Add the width to the span (outside the MathJax class, so uses outer em size, | |||
| // which makes it work even when minimum font size is in effect). | |||
| // | |||
| span.style.width = HTMLCSS.Em(Math.max(0,Math.round(math.bbox.w*this.em)+.25)/HTMLCSS.outerEm); | |||
| var W = math.bbox.w; | |||
| if (Math.abs(W) < .006) W = 0; else W = Math.max(0,Math.round(W*this.em)+.25); | |||
There was a problem hiding this comment.
W = Math.abs(W) < .006 ? 0 : Math.max(0,Math.round(W*this.em)+.25);
For readability.
|
Made your suggested change. |
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure rounded pixel values (which have a slight bit extra added to them) don't have the extra added to them when they are near 0. Resolves issue #1452.