Skip to content

Your CPU temperature is not supported yet #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yawllen opened this issue Nov 10, 2022 · 10 comments · Fixed by #100
Closed

Your CPU temperature is not supported yet #82

Yawllen opened this issue Nov 10, 2022 · 10 comments · Fixed by #100
Labels
bug Something isn't working
Milestone

Comments

@Yawllen
Copy link

Yawllen commented Nov 10, 2022

When starting the program выдает следующие

Снимок экрана 2022-11-10 200443

Win 11. Intel core i7 11700kf

@Yawllen Yawllen added the bug Something isn't working label Nov 10, 2022
@Yawllen
Copy link
Author

Yawllen commented Nov 10, 2022

Так же монитор зависает при запуске любой программы

@spectra9
Copy link

Although not a bug, since they clearly document it that CPU temp does not work on Windows, I do wish that they would eventually release a version that do. I mean, CPU temp is probably the first thing, or maybe second to GPU temp that people would want to monitor. A system monitor without the ability to monitor CPU temp, is just plain odd and frankly quite useless for me

@mathoudebine
Copy link
Owner

Hi, for the "CPU temperature not supported yet" message, I'm currently working on a new way to get CPU sensors from LibreHardwareMonitor instead of Python3 libraries. You can follow progress here: #52

@Yawllen can you try to run simple-program.py? Does it work with your screen? You may need to edit the simple-program.py file first to change REVISION or COM_PORT if needed.

@mathoudebine
Copy link
Owner

Hi @spectra9 and @Yawllen
A new beta release has been created with the support of LibreHardwareMonitor for sensors.
It should fix the issue with the CPU temperature.
https://github.com/mathoudebine/turing-smart-screen-python/releases/tag/2.2.0-beta.1
If you have time to test it, i would love your feedback!

@mathoudebine mathoudebine added this to the 2.2.0 milestone Dec 9, 2022
@mathoudebine mathoudebine linked a pull request Dec 9, 2022 that will close this issue
@spectra9
Copy link

spectra9 commented Dec 9, 2022

Downloaded and testing. After changing COM port setting (AUTO never works in my case), the temp for CPU is showing and seems to be in line with what RTSS is showing. Also I get message [WARNING] Network interface 'eth0' not found and 'wlan0' not found messages repeatedly, probably need to play around with the network interface name. Other than that, looking good so far, will test some more.

Edit: I notice the CPU freq is a bit off, e.g. it's showing 2-2.8 GHz, while in fact it's around 3.9-4.8 GHz. Not sure which sensor it's picking up though, I can't find similar value in RTSS CPU freq reading, every core is showing value aboe 3.6 GHz

Great work @mathoudebine, really appreciate it you keeping this project alive

@spectra9
Copy link

spectra9 commented Dec 9, 2022

Found test_librehardwaremonitor.py under LibreHardwareMonitor folder. Would be very cool if we could select which sensor to read from this list :-)

@spectra9
Copy link

spectra9 commented Dec 9, 2022

I think I found the problem with the CPU clock calculation. It's calculating the mean values of every Core# clocks, including the effective core clocks, which skew the results. So in order to make in line with RTSS value, I change the following lines

  for sensor in cpu.Sensors:
      if sensor.SensorType == Hardware.SensorType.Clock and "Core #" in str(sensor.Name):
          frequencies.append(float(sensor.Value))
  return mean(frequencies)

to this

for sensor in cpu.Sensors:
    if sensor.SensorType == Hardware.SensorType.Clock and "Core #" in str(sensor.Name) and "Effective" not in str(sensor.Name):
        frequencies.append(float(sensor.Value))
return max(frequencies)

@mathoudebine
Copy link
Owner

mathoudebine commented Dec 10, 2022

Many thanks for testing!
For the warning message with the network interfaces, you can edit the config.yaml file to either indicate the name of your interfaces or just leave the fields empty.

I did not have the "Effective" core clocks as sensors on my machine, i will apply your fix in the next commit.
You can open a "feature request" for your idea of selecting which sensor to use! 😉

@spectra9
Copy link

Hey Matt, thanks for the reply.
My CPU is AMD 5900X for reference and yes I do have the "Effective" core clock metric

I have updated the network interface name, so that's working fine now.

I've also tinkered around in replacing the GPU Mem Used metric to GPU Core Clock, was too lazy to add a new one so I just replace the one I don't use lol.
Next maybe onto some date/time formatting if I have time -> would be nice to have this configurable in the config too, along with some alignment choice hehe. But currently it's showing all it needed to show for my need

@mathoudebine
Copy link
Owner

Thanks again for your feedback, i've opened a feature request for custom date/time: #99
And one for the GPU Clock as a new metric #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants