Skip to content

OpenHardwareMonitor/LibreHardwareMonitor integration #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cyruz143 opened this issue Sep 20, 2022 · 7 comments · Fixed by #100
Closed

OpenHardwareMonitor/LibreHardwareMonitor integration #52

Cyruz143 opened this issue Sep 20, 2022 · 7 comments · Fixed by #100
Assignees
Labels
enhancement New feature or request windows
Milestone

Comments

@Cyruz143
Copy link

Cyruz143 commented Sep 20, 2022

Is your feature request related to a problem? If so, please describe the problem.
In theory this should hopefully resolve a few issues.

Describe the feature / solution to your problem you'd like
Integration of the Open Hardware Monitor (https://github.com/openhardwaremonitor/openhardwaremonitor) libs to replace various other limited 3rd party Python libs for Windows.

Describe alternatives you've considered / and or tested
I'm sure you were already aware of this, just thought it might save people making multiple issues requesting features/reporting bugs that are now known limitations of the currently used libs.

Additional considerations
I hope this fits your license seeing as OHM is open source, not sure if you want to include a .dll compiled by someone else.

@Cyruz143 Cyruz143 added the enhancement New feature or request label Sep 20, 2022
@mathoudebine
Copy link
Owner

Very good idea indeed!
I was also thinking about HWiNFO SDK but it is not open-source, so i like Open Hardware Monitor better
I plan to work on it soon!

@Cyruz143
Copy link
Author

Very good idea indeed! I was also thinking about HWiNFO SDK but it is not open-source, so i like Open Hardware Monitor better I plan to work on it soon!

Your choice might still be better. OHM is looking fairly quiet on Github, lots of issues not many actual commits going on...

@mathoudebine
Copy link
Owner

I found https://github.com/LibreHardwareMonitor/LibreHardwareMonitor a fork of Open Hardware Monitor still maintained, will give it a try

@mathoudebine mathoudebine changed the title Open Hardware Monitor integration OpenHardwareMonitor/LibreHardwareMonitor integration Sep 28, 2022
@mathoudebine mathoudebine self-assigned this Nov 14, 2022
@mathoudebine mathoudebine added this to the 3.0.0 milestone Nov 14, 2022
@mathoudebine
Copy link
Owner

Hi guys, I've started the development of the LibreHardwareMonitor integration for Windows platform. This will not be a quick task though.

I already found 3 ways:

  1. the preferred way: call the LibreHardwareMonitorLib.dll library directly from Python like https://github.com/gerfra/Temperature-Hardware-LibreHardwareMonitorLib
  2. use the WMI callbacks of the LibreHardwareMonitor.exe program like https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/master/LibreHardwareMonitor/TestScripts/basicwmi.py
  3. use the RestAPI of the LibreHardwareMonitor.exe program like https://github.com/Gokender/minotorr

@mathoudebine
Copy link
Owner

Hello @Cyruz143
The first beta release that supports LibreHardwareMonitor has been released!
https://github.com/mathoudebine/turing-smart-screen-python/releases/tag/2.2.0-beta.1
If you have time to test it, i would be happy to have your feedback!

@Cyruz143
Copy link
Author

Cyruz143 commented Dec 9, 2022

Awesome work! Will give it a run this weekend and let you know.

@mathoudebine mathoudebine linked a pull request Dec 9, 2022 that will close this issue
@Cyruz143
Copy link
Author

Ran it this weekend, no real issues to report, worked as expected! I did see the CPU effective clock being incorrect but that's been picked up in another ticket already with a suggested fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants