Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matplotlib version to 3.8 #146

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Feb 3, 2024

Updates:

  • The make logos target isn't needed, because there's a copy of the logo already in this repository
  • The second line of markers needed it's color setting correctly to show up now in 3.8

Otherwise I've checked the diffs and everything looks fine.

Note that this isn't the most recent release of 3.8 (3.8.4), but 3.8.2, the version that was out when I originally wrote this PR. I think we should just run with this, and I can do a follow up PR soon after to update to 3.9, and then 3.10. Doing it in stages across PRs seems to be the best thing to do to me, instead of trying to do a big jump in one go.

@dstansby
Copy link
Member Author

dstansby commented Feb 3, 2024

Hmm, logo2.png seems to have disappeared from https://github.com/matplotlib/matplotlib/tree/main/doc/_static at some point

@dstansby
Copy link
Member Author

dstansby commented Feb 3, 2024

Looks like there is a copy of that file in this repository anyway, so I just removed the bit that was trying to get it from matplotlib/matplotlib.

@dstansby dstansby marked this pull request as ready for review March 24, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant