Skip to content

Fix FixedFormatter #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix FixedFormatter #98

merged 1 commit into from
Dec 15, 2021

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Dec 7, 2021

  • use FixedLocator with FixedFormatter and change labels to something
    more appropriate for a FixedFormatter
  • add docstrings to pass flake8

The FixedFormatter example was completely wrong with misplaced minor tick labels (due to using FixedFormatter with MultipleLocator). The minor tick labels are a bit confusing as it's not shown how they were created, so I removed them altogether.

Current:

grafik

Fixed:

grafik

@rougier
Copy link
Member

rougier commented Dec 15, 2021

Thansk, that might explain why I needed the first empty label. Since you fixed it, maybe you use zero instead of the empty string.

- use FixedLocator with FixedFormatter and change labels to something
  more appropriate for a FixedFormatter
- add docstrings to pass flake8
@StefRe
Copy link
Contributor Author

StefRe commented Dec 15, 2021

maybe you use zero instead of the empty string

done
grafik

@rougier rougier merged commit eaa41d8 into matplotlib:master Dec 15, 2021
@StefRe StefRe deleted the fix/fixed_locator branch December 15, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants