Skip to content

Don't use deprecated cm.get_cmap in qt figureoptions. #25663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 11, 2023

One can directly pass the cmap str name to ScalarMappable.set_cmap.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

One can directly pass the cmap str name to ScalarMappable.set_cmap.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: Qt topic: color/color & colormaps labels Apr 11, 2023
@anntzer anntzer added this to the v3.7.2 milestone Apr 11, 2023
@ksunden ksunden merged commit 26e9f51 into matplotlib:main Apr 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 11, 2023
QuLogic added a commit that referenced this pull request Apr 12, 2023
…663-on-v3.7.x

Backport PR #25663 on branch v3.7.x (Don't use deprecated cm.get_cmap in qt figureoptions.)
@anntzer anntzer deleted the ugcm branch April 12, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Qt Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: color/color & colormaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants