Ploting Example Added With Data

[DrChandrakant]

Please Review Notebook Work

[DrChandrakant]

All Notebook Revised and Updated

[DrChandrakant]

All Notebooks were Updated. Kindly Review The Changes

[DanielGoldfarb]

I just tested and ran these notebooks locally on my pc. They demonstrate nicely how to use addplot and fill_between in the call to mpf.plot() to make nice looking indicator plots. I want to merge this Pull Request to include them in the repository.

However, these examples will be more valuable if they included at least some indication as to where the data came from, for the various columns actually used in these examples.

This indication could be as simple as including one or more markdown cells that describe either (1) where the data can be obtained, or (2) where the user can learn how to calculate the data. Alternatively, if you used your own code to obtain the columns, then perhaps include the code in the notebooks.

It would be nice also to include a reference to where users can learn more about each type of indicator demonstrated here.

Here are the columns used: Tenkan-sen, Kijun-sen, Chikou_Span, Senkou_Span_A, Senkou_Span_B, MACD_12_26_9, MACDh_12_26_9, MACDs_12_26_9, DCU_10_15, DCM_10_15, DCL_10_15

[DrChandrakant]

Thank You for Reviewing. I'm Updating the File With the Method To Obtain Ichimoku Cloud Technical

[DanielGoldfarb]

For what security is the price data in examples/data/t_data.csv?
Is that simulated data? (it goes into the future).

[DrChandrakant]

It is historical data of security name'NSE:TCS'.

[DanielGoldfarb]

@DrChandrakant Thank you. Just out of curiousity, can you explain to me why _15 is part of the names of DCU_10_15, DCM_10_15, and DCL_10_15. I understand the the _10 relates to the period used, but what does _15 signify? Thanks.

[DrChandrakant]

Single-input indicators:
For single-input indicators, the column name is formed by appending the indicator's name with an underscore (_) followed by the name of the input column. For example, if you calculate the Simple Moving Average (SMA) indicator on the "close" column row length, the resulting column name will be "sma_length".

Dual-input indicators:
For dual-input indicators, the column name is formed by appending the indicator's name with a double underscore (_ _) followed by the names of the input columns in alphabetical order. For example, if you calculate the donchian indicator using the 'df["HIGH"] and df["low"] columns with row length, the resulting column name will be "DCM_df["HIGH"][Length]_df["LOW"][length]".

[DanielGoldfarb]

@DrChandrakant
Thanks. That makes sense. But it does not agree with the formula you added to the code here:

#For Calculation Dochian Channel
period = 10
df['DCU_10_15'] = df['High'].rolling(period).max()
df['DCM_10_15'] = df['Low'].rolling(period).min()
df['DCL_10_15'] = (df['DCU_10_15`] + df['DCL_10_15']) / 2

Is it possible you meant something more like this?:

df['DCU_15'] = df['High'].rolling(15).max()
df['DCL_10'] = df['Low'].rolling(10).min()
df['DCM_10_15'] = (df['DCL_10'] + df['DCU_15']) / 2

Thank you for contributing these three examples to mplfinance. Ideally, I would like that the input file contain only OHLCV, and to have the indicators calculated within the example. I will do the work to make that change, however I want to be sure that I understand the formulas. Presently I feel a little confused regarding the Dochian Channel, as just described above.

[DrChandrakant]

Thank you for your suggestions. I Have Revised the Code and Suggestions Adopted. Some New Indicators Added Please Take Look.

[DanielGoldfarb]

Thank you for adding the calculations to all of the notebooks as requested above.

I just realized that one notebook still does not have the calculation in it: That is the Indicator_supertrend.ipynb. Much appreciated if you can please add that. Thank you.

[DrChandrakant]

Thanking You, Suptrend Calculation as an inline Function Updated.

[DanielGoldfarb]

@DrChandrakant

I have to ask you to remove, or undo, two of the last three commits. The Parabolic SAR is fine. It calculates Parabolic SAR from simple OHLC data (as I would like all of the examples to do), and it is consistent with the purpose of this Pull Request: to present several examples of Indicators.

However the other two commits should each be their own separate PR:

• the binancedark theme should be a separate PR.
• the highlighting mav prices on the y-axis should also be a separate PR.

The above two should not be together as one PR, but two new PRs separate from this one.

I have a lot or PR's to review and test, and I hope to finish this one in the next few days. Please make the above requested changes. Thank you.

[DrChandrakant]

Reverting Last Changes

[DanielGoldfarb]

@DrChandrakant
Thank you for the latest commits. Very good. Please don't make any more commits to this PR without asking me first. I am going to make a few small changes and then, hopefully, merge. Much appreciated! All the best. --Daniel