`ICON_ROOT` no longer needs to be a global. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dstansby merged 1 commit into matplotlib:main from samcunliffe:icon_root-no-longer-global

Jun 1, 2023

Collaborator

samcunliffe commented Jun 1, 2023

Now ICON_ROOT is only needed by one function in one class, it doesn't need to be global. (Unless we want it like that?)

Feel free to decline if undesired.


          ICON_ROOT no longer needs to be a global.

f5855c2

samcunliffe requested a review from dstansby

June 1, 2023 09:38

dstansby approved these changes

View reviewed changes

dstansby added this pull request to the merge queue

Merged via the queue into matplotlib:main with commit 6702c17

samcunliffe deleted the icon_root-no-longer-global branch

June 1, 2023 10:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet