A simple test of NapariNavigationToolbar._update_buttons_checked
.
#153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the codecov report, the
_update_buttons_checked
method of theNapariNavigationToolbar
is untested. So here's a (slightly) dumb UI test.If anyone knows a better way to compare two
QImage
s I'm really open to it.Buuuut it does seem like a nested
for
loop is the simplest way to do this. (For reference: there seems to be an unlooping way to shove the data into anumpy array
, but it involves pointers, and I'm not sure it's more readable. Readability counts?) I did check the time and the loopy way in this PR is ones of milliseconds.Testing:
Things I've done:
QImage.save
to dump the images.return True
withNotes for reviewers:
As mentioned: I am not a fan of the nested for loops.
Low priority and independent test. So don't rush to review this. It's unlikely to conflict 👍 .