Skip to content

De-duplicate single axis logic #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

De-duplicate single axis logic #168

merged 1 commit into from
Jun 14, 2023

Conversation

dstansby
Copy link
Member

Some minor de-duplication.

@dstansby dstansby marked this pull request as ready for review June 13, 2023 13:48
@dstansby dstansby requested a review from samcunliffe June 13, 2023 13:57
samcunliffe
samcunliffe approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of any way to have an inheritance diagram in the API docs?

@samcunliffe samcunliffe added this pull request to the merge queue Jun 14, 2023
Merged via the queue into matplotlib:main with commit 0d93aa1 Jun 14, 2023
@dstansby dstansby deleted the dedup-single-axis branch June 14, 2023 09:45
@dstansby
Copy link
Member Author

Do you know of any way to have an inheritance diagram in the API docs?

Yeah, just need to switch this line and then make sure graphviz is installed wherever we're building the docs:

napari-matplotlib/docs/conf.py

Line 52 in 0d93aa1

automodapi_inheritance_diagram = False

@dstansby dstansby mentioned this pull request Jun 15, 2023
Closed
@samcunliffe samcunliffe mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcunliffe samcunliffe samcunliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @samcunliffe