Skip to content

ENH: make summary log message about test results in general instead of failures #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2022
Merged

ENH: make summary log message about test results in general instead of failures #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pytest_mpl/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,11 +726,11 @@ def pytest_unconfigure(self, config):
kwargs["hash_library"] = result_hash_library.name
if 'html' in self.generate_summary:
summary = generate_summary_html(self._test_results, self.results_dir, **kwargs)
print(f"A summary of the failed tests can be found at: {summary}")
print(f"A summary of test results can be found at: {summary}")
if 'basic-html' in self.generate_summary:
summary = generate_summary_basic_html(self._test_results, self.results_dir,
**kwargs)
print(f"A summary of the failed tests can be found at: {summary}")
print(f"A summary of test results can be found at: {summary}")


class FigureCloser:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_pytest_mpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def test_hash_fails(tmpdir):
output = assert_pytest_fails_with(['--mpl', test_file, '--mpl-generate-summary=html'],
"doesn't match hash FAIL in library")
# We didn't specify a baseline dir so we shouldn't attempt to find one
print_message = "A summary of the failed tests can be found at:"
print_message = "A summary of test results can be found at:"
assert print_message in output, output
printed_path = Path(output.split(print_message)[1].strip())
assert printed_path.exists()
Expand Down