Skip to content

Add DeviceID to client.CSAPI #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2022
Merged

Add DeviceID to client.CSAPI #374

merged 2 commits into from
May 20, 2022

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented May 20, 2022

This adds the DeviceID created when building the Blueprint to the client.CSAPI

@S7evinK S7evinK requested a review from kegsay May 20, 2022 11:39
@S7evinK S7evinK marked this pull request as ready for review May 20, 2022 11:39
kegsay
kegsay approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that Complement will now fail to load up older images without device ID labels. Perhaps we can just warn instead of failing?

@S7evinK S7evinK merged commit 6451797 into main May 20, 2022
@S7evinK S7evinK deleted the s7evink/deviceid branch May 20, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S7evinK @kegsay