Faster room joins: Fix bug in awaitPartialStateJoinCompletion
#487
Conversation
`/sync` is not a good way to wait for a room to transition to full state, since it only waits for the full state at particular events instead of the whole room. This caused flakiness in the "Device list updates no longer reach departed servers after partial state join completes" test. Use `/members` instead to wait for partial state joins to complete.
| t, | ||
| "GET", | ||
| []string{"_matrix", "client", "v3", "rooms", room.RoomID, "members"}, | ||
| ) |
There was a problem hiding this comment.
I wonder if we should expose a way for clients to know if the room is partial, rather than trying to infer it? It even sounds like something we might want to expose in the UI?
There was a problem hiding this comment.
That sounds possibly useful. Though I wonder how much the concept of a partial state room (as opposed to a partial state event) is specific to the synapse implementation.
I suppose there are at least three reasons awaitPartialStateJoinCompletion might be used:
- to wait for a particular event to have full state
- to wait for the "current" state of the room to be a full state
- to wait for all events in the room to have full state (implies the previous 2)
I'd guess that clients and most tests are primarily interested in the 2nd property and it doesn't matter if there's still a partial state event somewhere back in the dag (which synapse doesn't allow, but a theoretical homeserver implementation might).
squahtx
deleted the
squah/faster_room_joins_device_list_tracking_fix_await_join_completion
branch
/syncis not a good way to wait for a room to transition to fullstate, since it only waits for the full state at particular events
instead of the whole room. This caused flakiness in the "Device list
updates no longer reach departed servers after partial state join
completes" test.
Use
/membersinstead to wait for partial state joins to complete.Fixes matrix-org/synapse#13977.
Fixes matrix-org/synapse#14010.