This repository was archived by the owner on Sep 10, 2024. It is now read-only.
Support using recovery tickets in the GraphQL SetPassword mutation #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/be_pwrecovery
branch
from
5d7b8a2 to
92c3426
Compare
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
92c3426
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://265e9617.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-be-pwrecovery.matrix-authentication-service-docs.pages.dev |
sandhose
reviewed
Jul 19, 2024
| @@ -542,7 +567,10 @@ impl UserMutations { | |||
| let user_id = NodeType::User.extract_ulid(&input.user_id)?; | |||
There was a problem hiding this comment.
Isn't that fundamentally a problem with this mutation? When you have a recovery ticket sent by email, you don't know the user_id; it is figured out from the recovery ticket directly
This means that either we need to make the user_id optional, or we need to make a separate mutation which only takes a recovery ticket
There was a problem hiding this comment.
Hmm. We could include the user ID in the link that's in the e-mail? But I guess that's redundant, so making the user ID optional for the recovery ticket might make sense then. I am not sure if this will turn out better or worse than a separate mutation, I don't want to duplicate the checks at least.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #172 (in a roundabout way) — we want to push the account recovery form into the React frontend code so it can share the code for the preview of password complexity.