This repository was archived by the owner on Sep 10, 2024. It is now read-only.
frontend: refactor password change form to extract double-input password creation inputs as new component #2994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
1a581b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0b65b41.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-fe-refactor-2inputpw.matrix-authentication-service-docs.pages.dev |
sandhose
approved these changes
Jul 24, 2024
| <> | ||
| <Form.Field name="new_password"> | ||
| <Form.Label> | ||
| {t("frontend.password_change.new_password_label")} |
There was a problem hiding this comment.
I guess keeping password_change as prefix for the password recovery makes sense. It won't when/if we start having this on the registration page; the label will probably have to be different
There was a problem hiding this comment.
ah true, that's a pity, but probably not too bad
| forceShowNewPasswordInvalid, | ||
| }: { | ||
| siteConfig: FragmentType<typeof CONFIG_FRAGMENT>; | ||
| forceShowNewPasswordInvalid: boolean; |
There was a problem hiding this comment.
That's a long prop name, but I'm fine with that :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of part of #172: by doing this refactoring, we can more easily support the same checks and metering in other forms.