This repository was archived by the owner on Sep 10, 2024. It is now read-only.
graphql: Expose CAPTCHA config and whether password registration is enabled #3017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6e1e25d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ac3967d.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-be-reg-siteconfig.matrix-authentication-service-docs.pages.dev |
sandhose
approved these changes
Jul 26, 2024
Comment on lines
+73
to
+79
| /// Which Captcha service is being used | ||
| #[derive(Enum, Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum CaptchaService { | ||
| RecaptchaV2, | ||
| CloudflareTurnstile, | ||
| HCaptcha, | ||
| } |
There was a problem hiding this comment.
I wondered whether this should be an enum with the site_key in each variant, so that we can extend later with provider-specific options and in the frontend we'd have to match on the __typename instead
but because this will never be actual public API, that won't be hard to change
There was a problem hiding this comment.
had the same line of thought
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #172 as I am working towards converting the registration form to React.