Skip to content

Voice message support #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Voice message support #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07552d3
autoplay in m.audio and m.recording event
aviraldg Apr 13, 2016
7660ffb
Merge m.recording with m.typing
aviraldg Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions event-schemas/examples/m.room.message#m.audio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"info": {
"duration": 2140786,
"size": 1563685,
"mimetype": "audio/mpeg"
"mimetype": "audio/mpeg",
"autoplay": true
},
"msgtype": "m.audio"
},
Expand All @@ -15,4 +16,4 @@
"room_id": "!jEsUZKDJdhlrceRyVU:localhost",
"type": "m.room.message",
"sender": "@example:localhost"
}
}
4 changes: 3 additions & 1 deletion event-schemas/examples/m.typing
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"type": "m.typing",
"room_id": "!z0mnsuiwhifuhwwfw:matrix.org",
"content": {
"user_ids": ["@alice:matrix.org", "@bob:example.com"]
"user_ids": ["@alice:matrix.org", "@bob:example.com"],
"typing": ["@bob:example.com"],
"recording": ["@alice:matrix.org"]
}
}
4 changes: 4 additions & 0 deletions event-schemas/schema/m.room.message#m.audio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
"duration": {
"type": "integer",
"description": "The duration of the audio in milliseconds."
},
"autoplay": {
"type": "boolean",
"description": "Hint that the audio should start playing automatically."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be explicit please.

If true, this indicates that the audio should start playing automatically. If false or missing, the audio should not start playing automatically.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intentional, not all clients may wish to respect that hint.

On Thu 23 Jun, 2016, 9:28 PM Kegsay, [email protected] wrote:

In event-schemas/schema/m.room.message#m.audio
#310 (comment):

@@ -37,6 +37,10 @@
"duration": {
"type": "integer",
"description": "The duration of the audio in milliseconds."

  •                    },

  •                    "autoplay": {

  •                        "type": "boolean",

  •                        "description": "Hint that the audio should start playing automatically."

Be explicit please.

If true, this indicates that the audio should start playing
automatically. If false or missing, the audio should not start playing
automatically.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-org/matrix-doc/pull/310/files/7660ffbc7ff76a3f4dbf7a677489c8819332ab5c#r68262297,
or mute the thread
https://github.com/notifications/unsubscribe/AAOlRKWWjbNTOvOFk37OjT_zT3a2EUG2ks5qOq0bgaJpZM4IGApw
.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that not all clients may wish to (given it is a "hint"). That's why you say SHOULD rather than leave it ambiguous.

}
}
}
Expand Down
20 changes: 17 additions & 3 deletions event-schemas/schema/m.typing
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "object",
"title": "Typing Event",
"description": "Informs the client of the list of users currently typing.",
"title": "Activity Event",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Activity" sounds like a presence thing to me - we already have currently_active etc there on the presence API. I think it's fine to call this a "typing event" still, but have the special case for a recording notification.

"description": "Informs the client of the list of active users (typing, recording, etc)",
"allOf": [{
"$ref": "core-event-schema/event.yaml"
}],
Expand All @@ -10,12 +10,26 @@
"type": "object",
"properties": {
"user_ids": {
"type": "array",
"items": {
"type": "string"
},
"description": "The list of user IDs active in this room, if any."
},
"typing": {
"type": "array",
"items": {
"type": "string"
},
"description": "The list of user IDs typing in this room, if any."
}
},
"recording": {
"type": "array",
"items": {
"type": "string"
},
"description": "The list of user IDs recording an audio message in this room, if any."
},
},
"required": ["user_ids"]
},
Expand Down