Refactor thread model to be created from the root event #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Jan 28, 2022
t3chguy
reviewed
Jan 28, 2022
src/models/thread.ts
Outdated
| } else { | ||
| this.root = event.getId(); | ||
| if (this.hasServerSideSupport && this.initialEventsFetched) { | ||
| if (event.getTs() > this.lastReply().getTs() && !this.findEventById(event.getId())) { |
There was a problem hiding this comment.
relying on timestamps between events for ordering is a no-go given different servers will have different clocks
There was a problem hiding this comment.
What would be the alternative? How can I know whether a message is newly incoming?
There was a problem hiding this comment.
I'm planning to merge this implementation using the age
It has cases in which is could cause the count to drift compared to the value returned by the HS. But this is never going to happen pre-release as we're going to use two homeservers with relatively synced clocks.
I'll create an issue to revisit that before the launch and will see whether we can find a better approach
t3chguy
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review alongside matrix-org/matrix-react-sdk#7670
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.