Skip to content

Fix error in uploadContent() when file is empty under Node.js #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Fix error in uploadContent() when file is empty under Node.js #2155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b7f263
Fix error in uploadContent() when file is empty under Node.js
hughns Feb 4, 2022
031af33
Make type safe check work
hughns Feb 7, 2022
0283510
Make comment actually make sense
hughns Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/http-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,20 @@ export class MatrixHttpApi {
queryParams.filename = fileName;
}

const headers: Record<string, string> = { "Content-Type": contentType };

// authedRequest uses `request` which is no longer maintained.
// `request` has a bug where if the body is zero bytes then you get an error: `Argument error, options.body`.
// See https://github.com/request/request/issues/920
// if body looks like a byte array and empty then set the Content-Length explicitly as a workaround:
if ((body as unknown as ArrayLike<number>).length === 0) {
headers["Content-Length"] = "0";
}

promise = this.authedRequest(
opts.callback, Method.Post, "/upload", queryParams, body, {
prefix: "/_matrix/media/r0",
headers: { "Content-Type": contentType },
headers,
json: false,
bodyParser,
},
Expand Down