Skip to content

Typescriptify crypto integration tests #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2022
Merged

Typescriptify crypto integration tests #2508

merged 3 commits into from
Jul 12, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Jul 8, 2022 •
edited by github-actions bot
Loading

This change is marked as an internal change (Task), so will not be included in the changelog.

@duxovni duxovni added the T-Task Tasks for the team like planning label Jul 8, 2022
@duxovni duxovni requested a review from a team as a code owner July 8, 2022 22:41
@duxovni
Copy link
Contributor Author

duxovni commented Jul 8, 2022

Oh right, I was working on top of #2505, I'll merge in develop once that gets merged and that should fix the type errors.

turt2live
turt2live requested changes Jul 8, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good - thank you! Mostly just need to add a bunch of return types :)

@duxovni duxovni requested a review from turt2live July 11, 2022 14:38
turt2live
turt2live approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

For future PRs, it's generally best to break each refactor into its own commit so the review is easier, though in this case it worked out well enough. We end up collapsing the commits down to one at merge, so they're effectively free :D

@duxovni duxovni merged commit 6fb40d4 into develop Jul 12, 2022
@duxovni duxovni deleted the fayed/typescriptify_crypto_tests branch July 12, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duxovni @turt2live