Skip to content

1:1 screenshare tests #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Aug 23, 2022

Fixes element-hq/element-call#548

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Tasks for the team like planning label Aug 23, 2022
@dbkr dbkr requested a review from a team as a code owner August 23, 2022 21:04
to prevent hanging tests

Also fix a null dereference as we may not have an invitee or opponent
member when sending voip events if not using to-device messages.
@dbkr dbkr requested a review from robintown August 24, 2022 09:05
@dbkr dbkr merged commit 9e1b126 into robertlong/group-call Aug 24, 2022
@dbkr dbkr deleted the dbkr/1to1_screenshare_tests branch August 24, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants