Improvements to megolm integration tests #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The megolm tests were making a few assumptions which they really shouldn't; in particular: * They were creating mock events with event_ids not starting `$`, and lacking `sender`, `origin_server_ts` and `unsigned` properties * They were not including the (now) required `keys.ed25519` property inside the ciphertext of an olm message. These work ok currently, but they aren't really correct, and they cause problems when testing the new rust implementation.
richvdh
force-pushed
the
rav/update_megolm_logs
branch
from
d76dfd2 to
3c0c0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The megolm tests were making a few assumptions which they really shouldn't; in particular:
They were creating mock events with event_ids not starting
$, and lackingsender,origin_server_tsandunsignedpropertiesThey were not including the (now) required
keys.ed25519property inside the ciphertext of an olm message.These work ok currently, but they aren't really correct, and they cause problems when testing the new rust implementation.
This change is marked as an internal change (Task), so will not be included in the changelog.