Improve output in github actions for jest tests #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
commented
Apr 11, 2023
| @@ -122,28 +122,12 @@ | |||
| "prettier": "2.8.7", | |||
| "rimraf": "^4.0.0", | |||
| "terser": "^5.5.1", | |||
| "ts-node": "^10.9.1", | |||
There was a problem hiding this comment.
this is needed to support having a jest config file in typescript
This was referenced Apr 11, 2023
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 12, 2023
Configure the Github Actions Reporter with silent: false, keeping it from swallowing failure reasons. Much the same as matrix-org/matrix-js-sdk#3269.
texuf
pushed a commit
to texuf/matrix-js-sdk
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two functional changes here:
silent: falsefor the GitHub Actions Reporter, which stops it swallowing failure reasons (otherwise it only puts it in an annotation)summaryreporter, which makes it easier to see why a test run as a whole failed.Setting
silent: falserequires us to use a config file, and using a config file overrides the config frompackage.json. So in the end it's easier just to have one config file with some intelligence for whether we are in GHA or not.This change is marked as an internal change (Task), so will not be included in the changelog.