Skip to content

Element-R: fix to device list change notifications #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 12, 2023

The rust crypto-sdk expects UserIds, not raw strings.

Follow-up to #3254


This change is marked as an internal change (Task), so will not be included in the changelog.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame that the Rust bindings don't have types, since I assume that would've helped here

@robintown robintown removed the request for review from andybalaam April 12, 2023 17:58
@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2023

@robintown there are types, they're just a bit...crap?

image

@richvdh
Copy link
Member Author

richvdh commented Apr 12, 2023

I asked @Hywan about making these types a bit better recently. I think basically it needs some complicated support in https://github.com/rustwasm/wasm-bindgen.

@richvdh richvdh added this pull request to the merge queue Apr 12, 2023
Merged via the queue into develop with commit ed8c326 Apr 12, 2023
@richvdh richvdh deleted the rav/element-r/fix-devicelist branch April 12, 2023 18:44
texuf pushed a commit to texuf/matrix-js-sdk that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants