-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatrixRTC: New membership manager #4726
Conversation
It was missing a flush.
And remove the IMembershipManager from it
This reverts commit 6af4730.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction this is heading 👍
Co-authored-by: Hugh Nimmo-Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes: I think splitting up the handler function has made a big difference in particular. I think I'm happy to give this a go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. It's great to get this over the line. 👍
@toger5 one more thing that could go in this PR, but could be a separate one, is adding some comments to say what is a workaround due to element-hq/synapse#17810 having not landed. This would make it easier to come back and remove the workaround later. |
I will do this as a seperate PR. |
Fixes: https://github.com/element-hq/voip-internal/issues/309
Part of element-hq/element-call#2972.
This does not yet use the new manager by default. It only runs the test suite with it.
Notes on error cases encountered when making HTTP requests to the Homeserver:
MatrixClient
stackRoomWidgetClient
stackError
withname
===AbortError
HttpError
MatrixError
ConnectionError
ConnectionError
as part of this PRChecklist
public
/exported
symbols have accurate TSDoc documentation.