Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixRTC: New membership manager #4726

Merged
merged 136 commits into from
Mar 11, 2025
Merged

MatrixRTC: New membership manager #4726

merged 136 commits into from
Mar 11, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Feb 19, 2025

Fixes: https://github.com/element-hq/voip-internal/issues/309
Part of element-hq/element-call#2972.

This does not yet use the new manager by default. It only runs the test suite with it.

Notes on error cases encountered when making HTTP requests to the Homeserver:

Type MatrixClient stack RoomWidgetClient stack
"Local" request timeout enforced by the Matrix client throws Error with name === AbortError ?
HTTP 5xx response from homeserver throws HttpError throws MatrixError
Network/socket error/timeout throws ConnectionError ?
Request timeout between widget and host Matrix client n/a now mapped to ConnectionError as part of this PR

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction this is heading 👍

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes: I think splitting up the handler function has made a big difference in particular. I think I'm happy to give this a go.

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. It's great to get this over the line. 👍

@hughns
Copy link
Member

hughns commented Mar 11, 2025

@toger5 one more thing that could go in this PR, but could be a separate one, is adding some comments to say what is a workaround due to element-hq/synapse#17810 having not landed.

This would make it easier to come back and remove the workaround later.

@toger5
Copy link
Contributor Author

toger5 commented Mar 11, 2025

@toger5 one more thing that could go in this PR, but could be a separate one, is adding some comments to say what is a workaround due to element-hq/synapse#17810 having not landed.

I will do this as a seperate PR.

@toger5 toger5 added this pull request to the merge queue Mar 11, 2025
Merged via the queue into develop with commit 9f9be70 Mar 11, 2025
30 checks passed
@toger5 toger5 deleted the toger5/new-MembershipManager branch March 11, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants