Add disableKeyStorage() to crypto API #4742
Merged
+84
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an all-in-one method for deleting all server side key storage on the user's account (as the doc hopefully explains).
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Mar 5, 2025
4 tasks
github-merge-queue bot
pushed a commit
to element-hq/element-web
that referenced
this pull request
Mar 14, 2025
* Add key storage toggle to Encryption settings * Keys in the acceptable order * Fix some tests * Fix import * Fix toast showing condition * Fix import order * Fix playwright tests * Fix bits lost in merge * Add key storage delete confirm screen * Fix hardcoded Element string * Fix type imports * Fix tests * Tests for key storage delete panel * Fix test * Type import * Test for the view model * Fix type import * Actually fix type imports * Test updating * Add playwright test & clarify slightly confusing comment * Show the advnced section whatever the state of key storage * Update screenshots * Copy css to its own file * Add missing doc & merge loading states * Add tsdoc & loading alt text to spinner * Turn comments into proper tsdoc * Switch to TypedEventEmitter and remove unnecessary loading state * Add screenshot * Use higher level interface * Merge the two hooks in EncryptionUserSettingsTab * Remove unused import * Don't check key backup enabled state separately as we don't need it for all the screens * Update snapshot * Use fixed recovery key function * Amalgamate duplicated CSS files * Have "key storage disabled" as a separate state * Update snapshot * Fix... bad merge? * Add backup enabled mock to more tests * More snapshots * Use defer util * Update to use EncryptionCardButtons * Update snapshots * Use EncryptionCardEmphasisedContent * Update snapshots * Update snapshot * Try screenshot from CI playwright * Try playwright screenshots again * More screenshots * Rename to match files * Test that 4S secrets are deleted * Make description clearer * Fix typo & move related states together * Add comment * More comments * Fix hook docs * restoreAllMocks * Update snapshot because pulling in upstream has caused IDs to shift * Switch icon as apparenty the error icon has changed * Update snapshot * Missing copyright * Re-order states and also sort out indenting * Remove phantom space * Clarify 'button' * Clarify docs more * Explain thinking behind updating * Switch to getActiveBackupVersion which checks that key backup is happining on this device, which is consistent with EX. * Add use of Key Storage Panel Co-authored-by: Richard van der Hoff <[email protected]> * Change key storage panel to be consistent ie. using getActiveBackupVersion(), and add comment * Add tsdoc Co-authored-by: Richard van der Hoff <[email protected]> * Use BACKUP_DISABLED_ACCOUNT_DATA_KEY in more places * Expand doc Co-authored-by: Richard van der Hoff <[email protected]> * Undo random yarn lock change * Use aggregate method for disabling key storage in matrix-org/matrix-js-sdk#4742 * Fix tests * Use key backup status event to update * Comment formatting Co-authored-by: Richard van der Hoff <[email protected]> * Fix comment & put check inside if statement * Add comment * Prettier * Fix comment * Update snapshot Which has gained nowrap due to 917d53a --------- Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an all-in-one method for deleting all server side key storage on the user's account (as the doc hopefully explains).
Checklist
public/exportedsymbols have accurate TSDoc documentation.