This repository was archived by the owner on Oct 21, 2019. It is now read-only.
Test timeline messages have correct display name with lazy loading #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support muting a logger and chaining calls
bwindels
changed the title
|
Part of element-hq/element-web#7287 |
dbkr
approved these changes
Sep 14, 2018
|
|
||
| const uuidv4 = require('uuid/v4'); | ||
|
|
||
| /* no pun intented */ |
| r.push(start + (i * step)); | ||
| } | ||
| return r; | ||
| } |
There was a problem hiding this comment.
ftr lodash also has this, but maybe not worth pulling it in for the sake of a 5 line function
There was a problem hiding this comment.
👍 next time a need a lodash method I'll import it
|
Part of element-hq/element-web#7287 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed a bit of infrastructure to create more users without spinning up more browsers, as you need at least 3 users to test the use case.
The test does the follow:
More lazy loading tests are coming based on this work.