Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Interpret backspace at start of style block as block style toggle #1232

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Interpret backspace at start of style block as block style toggle #1232

merged 1 commit into from
Jul 19, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Jul 18, 2017 •
edited
Loading

@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Jul 18, 2017 •
edited
Loading

Makes more sense with CSS to make the blocks more distinguished. Done - element-hq/element-web#4639

@lukebarnard1 lukebarnard1 mentioned this pull request Jul 19, 2017
Closed
dbkr
dbkr approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm becoming increasingly terrified of this large block of very complex, untested code that I don't really understand, but OK.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Jul 19, 2017
@lukebarnard1 lukebarnard1 merged commit 75ca141 into develop Jul 19, 2017
@lukebarnard1
Copy link
Contributor Author

I'm becoming increasingly terrified of this large block of very complex, untested code that I don't really understand

We have the bare-minimum amount of testing for the RTE and I agree that we it is too complex and that it should have more tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr