This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix black-on-black GIF icon for stickers #2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text colour ended up being the link colour on images because the whole image is in an `a`, but stickers are not so it got the default font colour, which might be black. Define an explicit colour. Also set pointer-events: none so you can hover over the gif icon too (I managed to make the message panel small which made the icon cover most the image, so this prevented the gif from animating at all). Fixes element-hq/element-web#8004
jryans
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text colour ended up being the link colour on images because the
whole image is in an
a, but stickers are not so it got the defaultfont colour, which might be black. Define an explicit colour.
Also set pointer-events: none so you can hover over the gif icon
too (I managed to make the message panel small which made the icon
cover most the image, so this prevented the gif from animating
at all).
Fixes element-hq/element-web#8004