Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Support voice messages on Safari #5989

Merged
merged 4 commits into from
May 11, 2021
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented May 7, 2021

Tested on Mac OS Big Sur Safari 14.0.3

  • Recording
  • Composer playback
  • Sending
  • Timeline playback

Fixes element-hq/element-web#17140


Requires element-hq/element-web#17193


turt2live added 3 commits May 6, 2021 21:43
This helps return the microphone access to the user.
Tested on MacOS Big Sur, Safari 14.0.3
Here we just override the workers because we're not expecting to be able to test them this way. The code paths involved shouldn't be touched.
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for working on this!

How much of this can be removed once there's 2 major Safari versions with the modern API? All of it? Please file an issue to track.

@turt2live
Copy link
Member Author

@turt2live turt2live merged commit d1cfde6 into develop May 11, 2021
@turt2live turt2live deleted the travis/voicemessages/safari branch May 11, 2021 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice messages: Safari support
2 participants