Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add new threads to the panel as they are discovered #7688

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Feb 1, 2022

Fixes element-hq/element-web#20555
To review alongside matrix-org/matrix-js-sdk#2148


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://61f94a2f7bcc72e801f55c92--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner February 1, 2022 12:12
@@ -231,6 +231,35 @@ const ThreadPanel: React.FC<IProps> = ({ roomId, onClose, permalinkCreator }) =>
if (timelineSet) ref.current.refreshTimeline();
});

useEventEmitter(room, ThreadEvent.New, async thread => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a type for thread

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@germain-gg germain-gg enabled auto-merge (squash) February 1, 2022 14:53
@germain-gg germain-gg merged commit 5973d72 into develop Feb 1, 2022
@germain-gg germain-gg deleted the gsouquet/threads-discoverability-20555 branch February 1, 2022 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The thread list is not being filled up with threads when scrolling the main timeline
2 participants