This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add config option to autorageshake when key backup is not enabled #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 8, 2022 12:31
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
added 2 commits
February 10, 2022 18:36
Signed-off-by: Kerry Archibald <[email protected]>
germain-gg
approved these changes
Feb 11, 2022
src/settings/Settings.tsx
Outdated
| displayName: _td("Automatically send debug logs when key backup is not functioning"), | ||
| supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS_WITH_CONFIG, | ||
| default: false, | ||
| controller: new ReloadOnChangeController(), |
There was a problem hiding this comment.
Toggling that setting probably does not warrant a whole app restart?
At least there's nothing I can spot here that would warrant that, but might have missed it
Suggested change
| controller: new ReloadOnChangeController(), |
Signed-off-by: Kerry Archibald <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hook in encryption setup to automatically send a rageshake report when:
https://element-io.atlassian.net/browse/PSE-327
task: https://github.com/orgs/vector-im/projects/16#card-76253406
Example report: https://github.com/matrix-org/element-web-rageshakes/issues/10530
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr7741--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.